Add Abseil from Chromium 114.0.5735.331 #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2189 +/- ##
==========================================
+ Coverage 58.53% 58.55% +0.01%
==========================================
Files 1908 1907 -1
Lines 94585 94568 -17
==========================================
+ Hits 55369 55377 +8
+ Misses 39216 39191 -25 ☔ View full report in Codecov by Sentry. |
jellefoks
force-pushed
the
feature/add-abseil
branch
11 times, most recently
from
6abc2e6 to
976244d
Compare
third_party/abseil-cpp/absl/base/internal/spinlock_starboard.inc
Outdated
Show resolved
Hide resolved
git-subtree-dir: third_party/abseil-cpp git-subtree-split: fed499399d3f44d3a7957549d493bf30a5d8c867
jellefoks
force-pushed
the
feature/add-abseil
branch
from
976244d to
132e6a5
Compare
|
LGTM, but I believe the subtree squash commit needs to be added. @dahlstrom-g would you please also take a look? |
jellefoks
force-pushed
the
feature/add-abseil
branch
from
132e6a5 to
8ddb00f
Compare
dahlstrom-g
changed the title
dahlstrom-g
force-pushed
the
feature/add-abseil
branch
3 times, most recently
from
ae31e54 to
290dc80
Compare
dahlstrom-g
approved these changes
Jan 17, 2024
dahlstrom-g
reviewed
Jan 17, 2024
jellefoks
force-pushed
the
feature/add-abseil
branch
from
5ff2190 to
49a95f2
Compare
third_party/abseil-cpp/absl/random/internal/randen_detect_starboard.cc
Outdated
Show resolved
Hide resolved
b/319139474
b/319139474
… instead of a shim to base::Optional.
This removes non-Starboardized files from the build with Cobalt toolchain. b/150410605
dahlstrom-g
force-pushed
the
feature/add-abseil
branch
from
9eb66a8 to
e21ef69
Compare
dahlstrom-g
approved these changes
Jan 18, 2024
andrewsavage1
approved these changes
Jan 18, 2024
dahlstrom-g
force-pushed
the
feature/add-abseil
branch
from
e21ef69 to
613cf30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds abseil (continuation/replacement of #2179).
b/319139474
This prepares for b/315503544 (and others).