Cherry pick PR #1473: Rename libstarboard_platform_group.so to libstarboard.so.{sb_version} #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-1473 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/7342560120 for details. |
niranjanyardi
force-pushed
the
cherry-pick-24.lts.1+-1473
branch
from
f5d3ef4 to
531217e
Compare
niranjanyardi
approved these changes
Dec 28, 2023
kaidokert
force-pushed
the
cherry-pick-24.lts.1+-1473
branch
2 times, most recently
from
9c4cb40 to
7ed7b00
Compare
…#1473) b/298729481 Rename libstarboard_platform_group.so to libstarboard.so.{starboard_version} according to linux package naming standards https://www.debian.org/doc/debian-policy/ch-sharedlibs.html Rename cast library from libcast_starboard_api.so to llibcast_starboard_api.so.{starboard_version} For windows based platforms the library is renamed to libstarboard.{extension} https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-assemblies-and-dlls Change-Id: Ide88ea21961487b70803dcab910c5ad8c09d70cc (cherry picked from commit a06e783)
niranjanyardi
force-pushed
the
cherry-pick-24.lts.1+-1473
branch
from
7ed7b00 to
6cfd679
Compare
|
Goign to cp this change instead: #1952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1473
b/298729481
Rename libstarboard_platform_group.so to libstarboard.so.{starboard_version} according to linux package naming standards https://www.debian.org/doc/debian-policy/ch-sharedlibs.html
Rename cast library from libcast_starboard_api.so to llibcast_starboard_api.so.{starboard_version}
For windows based platforms the library is renamed to libstarboard.{extension} https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-assemblies-and-dlls
Change-Id: Ide88ea21961487b70803dcab910c5ad8c09d70cc