Skip to content

Commit

Permalink
[android] Fix low fps checking in video_decoder.cc
Browse files Browse the repository at this point in the history
The mime attribute "framerate" is used to specify the frame rate of the
video, and the previous implementation incorrectly used "fps" as the
mime attribute name.

b/286121490

Change-Id: Iaec70f33ab625224e8a31eba96db0bea063f0a8a
  • Loading branch information
xiaomings committed Apr 26, 2024
1 parent c0dfb97 commit abeea0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion starboard/android/shared/video_decoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ bool IsSoftwareDecodeRequired(const std::string& max_video_capabilities) {

bool is_low_resolution = mime_type.GetParamIntValue("width", 1920) <= 432 &&
mime_type.GetParamIntValue("height", 1080) <= 240;
bool is_low_fps = mime_type.GetParamIntValue("fps", 30) <= 15;
bool is_low_fps = mime_type.GetParamIntValue("framerate", 30) <= 15;

if (is_low_resolution && is_low_fps) {
// Workaround to be compatible with existing backend implementation.
Expand Down

0 comments on commit abeea0d

Please sign in to comment.