Skip to content

Commit

Permalink
Merge branch 'main' into add-sb17-builders
Browse files Browse the repository at this point in the history
  • Loading branch information
madhurajayaraman authored Jul 31, 2024
2 parents cac8c6a + 1f7d8a5 commit a2824fe
Show file tree
Hide file tree
Showing 14 changed files with 413 additions and 302 deletions.
2 changes: 1 addition & 1 deletion starboard/build/config/base_configuration.gni
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ declare_args() {

# The Starboard API version of the current build configuration. The default
# value is meant to be overridden by a Starboard ABI file.
sb_api_version = 16
sb_api_version = 17

# Enables embedding Cobalt as a shared library within another app. This
# requires a 'lib' starboard implementation for the corresponding platform.
Expand Down
2 changes: 0 additions & 2 deletions starboard/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ static_library("common") {
"system_property.h",
"thread.cc",
"thread.h",
"thread_collision_warner.cc",
"thread_collision_warner.h",
"time.cc",
"time.h",
]
Expand Down
81 changes: 0 additions & 81 deletions starboard/common/thread_collision_warner.cc

This file was deleted.

217 changes: 0 additions & 217 deletions starboard/common/thread_collision_warner.h

This file was deleted.

2 changes: 1 addition & 1 deletion starboard/configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

// The maximum API version allowed by this version of the Starboard headers,
// inclusive. The API version is not stable and is open for changes.
#define SB_MAXIMUM_API_VERSION 16
#define SB_MAXIMUM_API_VERSION 17

// --- Common Detected Features ----------------------------------------------

Expand Down
4 changes: 4 additions & 0 deletions starboard/linux/x64x11/system_get_property_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ const char kModelName[] = "ModelName";
const char kPlatformName[] = "X11; Linux x86_64";
const char kSystemIntegratorName[] = "SystemIntegratorName";

#if SB_API_VERSION == 17
const char kModelYear[] = "2026";
#endif // SB_API_VERSION == 17

#if SB_API_VERSION == 16
const char kModelYear[] = "2025";
#endif // SB_API_VERSION == 16
Expand Down
49 changes: 49 additions & 0 deletions starboard/nplb/nplb_evergreen_compat_tests/sabi_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,55 @@ const char* kSabiJsonIdX64Sysv =
"\"target_arch\":\"x64\",\"target_arch_sub\":\"\",\"word_size\":64}";
#endif // SB_API_VERSION == 16

#if SB_API_VERSION == 17
const char* kSabiJsonIdArmHardfp =
"{\"alignment_char\":1,\"alignment_double\":8,\"alignment_float\":4,"
"\"alignment_int\":4,\"alignment_llong\":8,\"alignment_long\":4,"
"\"alignment_pointer\":4,\"alignment_short\":2,\"calling_convention\":"
"\"eabi\",\"endianness\":\"little\",\"floating_point_abi\":\"hard\","
"\"floating_point_fpu\":\"vfpv3\",\"sb_api_version\":17,\"signedness_of_"
"char\":\"signed\",\"signedness_of_enum\":\"signed\",\"size_of_char\":1,"
"\"size_of_double\":8,\"size_of_enum\":4,\"size_of_float\":4,\"size_of_"
"int\":4,\"size_of_llong\":8,\"size_of_long\":4,\"size_of_pointer\":4,"
"\"size_of_short\":2,\"target_arch\":\"arm\",\"target_arch_sub\":\"v7a\","
"\"word_size\":32}";

const char* kSabiJsonIdArmSoftfp =
"{\"alignment_char\":1,\"alignment_double\":8,\"alignment_float\":4,"
"\"alignment_int\":4,\"alignment_llong\":8,\"alignment_long\":4,"
"\"alignment_pointer\":4,\"alignment_short\":2,\"calling_convention\":"
"\"eabi\",\"endianness\":\"little\",\"floating_point_abi\":\"softfp\","
"\"floating_point_fpu\":\"vfpv3\",\"sb_api_version\":17,\"signedness_of_"
"char\":\"signed\",\"signedness_of_enum\":\"signed\",\"size_of_char\":1,"
"\"size_of_double\":8,\"size_of_enum\":4,\"size_of_float\":4,\"size_of_"
"int\":4,\"size_of_llong\":8,\"size_of_long\":4,\"size_of_pointer\":4,"
"\"size_of_short\":2,\"target_arch\":\"arm\",\"target_arch_sub\":\"v7a\","
"\"word_size\":32}";

const char* kSabiJsonIdArm64 =
"{\"alignment_char\":1,\"alignment_double\":8,\"alignment_float\":4,"
"\"alignment_int\":4,\"alignment_llong\":8,\"alignment_long\":8,"
"\"alignment_pointer\":8,\"alignment_short\":2,\"calling_convention\":"
"\"aarch64\",\"endianness\":\"little\",\"floating_point_abi\":\"\","
"\"floating_point_fpu\":\"\",\"sb_api_version\":17,\"signedness_of_char\":"
"\"signed\",\"signedness_of_enum\":\"signed\",\"size_of_char\":1,\"size_of_"
"double\":8,\"size_of_enum\":4,\"size_of_float\":4,\"size_of_int\":4,"
"\"size_of_llong\":8,\"size_of_long\":8,\"size_of_pointer\":8,\"size_of_"
"short\":2,\"target_arch\":\"arm64\",\"target_arch_sub\":\"v8a\",\"word_"
"size\":64}";

const char* kSabiJsonIdX64Sysv =
"{\"alignment_char\":1,\"alignment_double\":8,\"alignment_float\":4,"
"\"alignment_int\":4,\"alignment_llong\":8,\"alignment_long\":8,"
"\"alignment_pointer\":8,\"alignment_short\":2,\"calling_convention\":"
"\"sysv\",\"endianness\":\"little\",\"floating_point_abi\":\"\",\"floating_"
"point_fpu\":\"\",\"sb_api_version\":17,\"signedness_of_char\":\"signed\","
"\"signedness_of_enum\":\"signed\",\"size_of_char\":1,\"size_of_double\":8,"
"\"size_of_enum\":4,\"size_of_float\":4,\"size_of_int\":4,\"size_of_"
"llong\":8,\"size_of_long\":8,\"size_of_pointer\":8,\"size_of_short\":2,"
"\"target_arch\":\"x64\",\"target_arch_sub\":\"\",\"word_size\":64}";
#endif // SB_API_VERSION == 17

class SabiTest : public ::testing::Test {
protected:
SabiTest() {}
Expand Down
Loading

0 comments on commit a2824fe

Please sign in to comment.