Set default gn --check to false (#4438)

b/377295011 Disable running gn --check by default
youtube · Nov 15, 2024 · 02c7026 · 02c7026
1 parent f4c26a2
commit 02c7026
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/actions/build/action.yaml b/.github/actions/build/action.yaml
@@ -31,7 +31,7 @@ runs:
       - name: gn gen
         run: |
           cd src
-          cobalt/build/gn.py -p ${{ matrix.platform }} -C ${{ matrix.config }} --no-check
+          cobalt/build/gn.py -p ${{ matrix.platform }} -C ${{ matrix.config }}
         shell: bash
       - name: gn dump args
         run: |

diff --git a/cobalt/build/gn.py b/cobalt/build/gn.py
@@ -154,7 +154,8 @@ def main(out_directory: str, platform: str, build_type: str,
       '`gn args <out_directory>` to edit it instead.')
   parser.add_argument(
       '--no-check',
-      default=False,
+      # TODO: b/377295011 - Enable gn --check
+      default=True,
       action='store_true',
       help='Pass this flag to disable the header dependency gn check.')
   script_args, gen_args = parser.parse_known_args()