Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to typeahead.js v0.10.3 #12

Closed

Conversation

felixbuenemann
Copy link
Contributor

From the official Changelog:

0.10.3 July 10, 2014

Bug fixes

@ldonnet
Copy link

ldonnet commented Jul 22, 2014

Hello,

I see that you have done a great work to integrate typehead.
Could you release a new version or could we help us to create a new one?

Thanks
Luc

@felixbuenemann
Copy link
Contributor Author

@ldonnet You can just use the following in your Gemfile to use the new version until a new gem is released:

gem 'twitter-typeahead-rails', github: 'felixbuenemann/twitter-typeahead-rails', branch: 'typeahead.js-0.10.3'

Or fork my repo and use your fork as a source.

Another alternative is to use the rails-assets gem source, which always has up to date versions of all bower compatible js libs: https://rails-assets.org/

Note that when using rails-assets.org you should replace jquery-rails and instead use jquery and jquery-ujs gems from the rails-assets.org source so you don't get a duplicate jquery include.

@ldonnet
Copy link

ldonnet commented Jul 23, 2014

Thanks @felixbuenemann for your answer and tips. I didn't know that https://rails-assets.org/ is always up to date with all bower compatible js libs.

@yourabi
Copy link
Owner

yourabi commented Jul 24, 2014

I'll review...and merge or comment...

@felixbuenemann
Copy link
Contributor Author

I would probably skip merging this.

0.10.3 has a regression when used with multiple remote sources. I'll update the assets to 0.10.5 and make a new PR once I've verified it works fine.

@yourabi
Copy link
Owner

yourabi commented Aug 16, 2014

Awesome, thanks.

@felixbuenemann
Copy link
Contributor Author

Closing in favor of PR #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants