Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the pid file with integration test #762

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Mar 5, 2022

Fix: #757

@utam0k utam0k force-pushed the fix/not-found-pid-file branch from 3f069b0 to d9d1efa Compare March 5, 2022 06:55
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
I checked by pulling #758 and applying the patch which allowed it to pass the pidfile test.
Although this makes me wonder why the test was passing originally 🤔

Comment on lines +184 to +187
let part_path = match part.next() {
None => break,
Some(part) => PathBuf::from(part),
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +86 to +89
let r = match tests {
None => s.spawn(move |_| tg.run_all()),
Some(tests) => s.spawn(move |_| tg.run_selected(tests)),
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@utam0k
Copy link
Member Author

utam0k commented Mar 5, 2022

me too 🤔

Although this makes me wonder why the test was passing originally 🤔

@utam0k utam0k merged commit 86acc4d into youki-dev:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix youki's original integration test fialed
2 participants