Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /dev/null inside of the container #630

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

adrianreber
Copy link
Contributor

If stdin, stdout or stderr are redirected to /dev/null they need to be
pointed to /dev/null in the container. This is necessary for
checkpointing as CRIU cannot checkpoint processes using devices outside
of the container.

Fixes: #629

Copy link
Collaborator

@Furisto Furisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, you just need to run cargo fmt --all to resolve the CI failure.

@utam0k utam0k added the enhancement New feature or request label Jan 22, 2022
If stdin, stdout or stderr are redirected to /dev/null they need to be
pointed to /dev/null in the container. This is necessary for
checkpointing as CRIU cannot checkpoint processes using devices outside
of the container.

Signed-off-by: Adrian Reber <[email protected]>
@adrianreber adrianreber force-pushed the 2022-01-21-reopen-dev-null branch from 53b152b to 07a87eb Compare January 22, 2022 09:39
@adrianreber
Copy link
Contributor Author

Fixed formating

@Furisto
Copy link
Collaborator

Furisto commented Jan 22, 2022

lgtm

@Furisto Furisto merged commit de4dcf8 into youki-dev:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-open /dev/null inside the container
3 participants