-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure exec command can find config.json #616
Conversation
@Furisto I'm sorry, but could you rebase? |
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 70.01% 69.99% -0.02%
==========================================
Files 82 82
Lines 10933 10936 +3
==========================================
Hits 7655 7655
- Misses 3278 3281 +3 |
@utam0k PTAL |
@Furisto Thanks for your PR 😍 $ sudo podman run --name test -it busybox sh
/
# and in another console
$ sudo podman exec -it test sh |
@utam0k The exec command is already broken. This fixes one of the issues (missing config.json), but there is another issue which I alluded to the in the description of this issue which breaks the exec command later on.
Unless I am misunderstanding your meaning, it is in the bundle directory. |
Oh, my local was wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Partially fixes #584. While fixing this I discovered another issue, which I will follow up in the next PR.