Add test process rlimits #2977
Add test process rlimits #2977
Conversation
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
…nto add-test-process-rlimits
|
Also, are there any safe alternatives to get the rlimits, maybe via nix crate? https://docs.rs/nix/latest/nix/sys/resource/fn.getrlimit.html |
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
|
I fixed the code, remove unsafe code and change to use nix. |
|
@YJDoc2 HI, I've fixed the code according to the comments. Could you please check the code? |
There was a problem hiding this comment.
two nitpicks, but not blocking change. I'll merge this PR by tom if you don't respond. (Even a comment not necessarily code change)
To be clear, the nitpicks are not major, so I'm fine for merging this as is, and will merge by tom unless you comment otherwise.
| let (soft_limit, hard_limit) = getrlimit(change_resource_type(spec_rlimit.typ())).unwrap(); | ||
| if spec_rlimit.hard() != hard_limit { | ||
| eprintln!( | ||
| "error type of {:?} hard rlimit expected {:?} , got {:?}", |
There was a problem hiding this comment.
| "error type of {:?} hard rlimit expected {:?} , got {:?}", | |
| "error: rlimit mismatch {:?} hard rlimit expected {:?} , got {:?}", |
Same for soft limit
| } | ||
| } | ||
|
|
||
| fn change_resource_type(resource_type: PosixRlimitType) -> Resource { |
There was a problem hiding this comment.
| fn change_resource_type(resource_type: PosixRlimitType) -> Resource { | |
| fn to_nix_resource(resource_type: PosixRlimitType) -> Resource { |
my reasoning is change_resource_type does not express what exactly we are changing it to, but from fn signature it is understandable, so not a strict change req.
|
Going ahead and merging |
This implements the process_rlimits validation in #361