Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up userns in a straightforward way #2548

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Nov 29, 2023

It is just a functionalization. Easier to test.

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 29, 2023
@utam0k utam0k requested a review from Furisto November 29, 2023 12:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Merging #2548 (465d0bb) into main (ac20fc3) will increase coverage by 0.03%.
Report is 7 commits behind head on main.
The diff coverage is 53.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2548      +/-   ##
==========================================
+ Coverage   65.91%   65.95%   +0.03%     
==========================================
  Files         133      133              
  Lines       16872    16890      +18     
==========================================
+ Hits        11122    11140      +18     
  Misses       5750     5750              

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to fix the lint, otherwise lgtm

Signed-off-by: utam0k <[email protected]>
@utam0k
Copy link
Member Author

utam0k commented Nov 30, 2023

Thanks for your review 🙇

@utam0k utam0k enabled auto-merge (squash) November 30, 2023 11:19
@utam0k utam0k merged commit 18bed8d into youki-dev:main Dec 4, 2023
15 checks passed
This was referenced Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants