Implemented more thiserror for libcontainer (Part 2)
#1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
9 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
- Coverage 67.71% 67.56% -0.15%
==========================================
Files 124 125 +1
Lines 14205 14199 -6
==========================================
- Hits 9619 9594 -25
- Misses 4586 4605 +19 |
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
utam0k
approved these changes
May 6, 2023
|
@squili |
squili
suggested changes
May 6, 2023
Signed-off-by: yihuaf <[email protected]>
squili
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented more
thiserrorfor the libcontainer. This PR covers most of the low hanging fruits with smaller crates. Note, I decided to add a new syscall error wrapper that wraps thenix::Error,std::io::Error, and our own syscall crate. This aims to simplify where we call syscalls from 3 different sources and can simplify/unify many errors.CC @squili PTAL
Part of #1377