rewrote the bpf example #1877
Merged
rewrote the bpf example #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
+ Coverage 68.16% 68.17% +0.01%
==========================================
Files 122 122
Lines 14011 14011
==========================================
+ Hits 9550 9552 +2
+ Misses 4461 4459 -2 |
|
Hmm... Sorry, but I don't remember. The cgroup v2 devices are special, and we wanted to test that. Either way, I think it's time to take a proper look at cgroup v2 devices. |
utam0k
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the bpf example in the
libcgroupswas never compiled as part of the normal routine. Therefore, it is completely outdated and requires an overhaul.Question: I rewrote the code, but we are missing the context of this example. @Furisto @utam0k Do you guys recall the context around this snippets of code? We should document this in the libcgroups README.
Fix #1499