Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override log opt when specified more than once #1847

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Override log opt when specified more than once #1847

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4318de8
Override log opt when specified more than once
boaz0 Apr 24, 2023
2bf4e16
Add a comment about the log flag "override" behavior
boaz0 Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/liboci-cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ pub struct GlobalOpts {
// Example in future : '--debug change log level to debug. (default: "warn")'
#[clap(long)]
pub debug: bool,
#[clap(short, long)]
// Set a consistent behavior like in runc and crun: set log to the last given value
#[clap(short, long, overrides_with("log"))]
pub log: Option<PathBuf>,
#[clap(long)]
pub log_format: Option<String>,
Expand Down