Modify pointer type from i8 to c_char

[kemkemG0]

[Environment Info]

root ➜ /workspaces/youki  $ uname -a
Linux 80f9ee1dbb2e 5.15.49-linuxkit  aarch64  GNU/Linux

Description

When running the command:

$ make unittest

I encountered the following error:

error[E0308]: mismatched types
  --> crates/libcgroups/src/v2/devices/bpf.rs:39:22
   |
39 |             log_buf: ptr::null_mut::<i8>(),
   |                      ^^^^^^^^^^^^^^^^^^^^^ expected `u8`, found `i8`
   |
   = note: expected raw pointer `*mut u8`
              found raw pointer `*mut i8`

I found a similar error in another repository, which can be found here: remacs/remacs#1393 (comment)

My understanding is that the pointer type on ARM and x86 is defined differently. Following the advice on the issue, I used the c_char type instead of i8.

I also noticed that while the issue uses libc::c_char, this repository uses ::std::os::raw::c_char in some other parts. After reading this thread: https://users.rust-lang.org/t/libc-c-char-vs-std-os-c-char/21198, I decided to use ::std::os::raw::*.

Therefore, I used ::std::os::raw::c_char in my modifications.

[codecov-commenter]

Codecov Report

Merging #1792 (3849a97) into main (edd63c8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1792   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         121      121           
  Lines       13325    13325           
=======================================
  Hits         9146     9146           
  Misses       4179     4179           

[kemkemG0]

Well, I think I made a mistake on the GitHub operation... I'll fix it soon ;(

maybe fixed :)

[kemkemG0]

Now I realized that #1579 is related.

[Furisto]

Hey @kemkemG0 changes looks good. Can you please rebase to get rid of the merge commits? The integration test is failing because of a clippy lint. Would you like to fix that as well or should we do it separately?

[kemkemG0]

Hi, @Furisto thanks for your review. I will rebase to get rid of the merge commits.

However, I don't see why the clippy lint fails as I didn't modify the part clippy is warning.

Should I fix that part as it suggests?

I apologize if I misunderstood the point ;)

[kemkemG0]

I apologize for messing up the commit logs .. :(
I am not used to rebasing or dealing with forked repo...
I'll fix it soon

Though some logs are here, I see only one commit now.

Is it fixed?

[kemkemG0]

Hi, @Furisto thanks for your review. I will rebase to get rid of the merge commits.

However, I don't see why the clippy lint fails as I didn't modify the part clippy is warning.

Should I fix that part as it suggests?

I apologize if I misunderstood the point ;)

Now, the test has passed somehow :)

[Furisto]

Thanks @kemkemG0