Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to youki binary in dockerd command #1781

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

kemkemG0
Copy link
Contributor

@kemkemG0 kemkemG0 commented Apr 6, 2023

Update README.md with correct --add-runtime path

Hi, I noticed that the README.md file still contains the old target path for the --add-runtime flag.

Specifically, this part:

$ dockerd --experimental --add-runtime="youki=$(pwd)/target/x86_64-unknown-linux-gnu/debug/youki"

I think this doesn't match the updated target path in the Makefile.

So I update the path to $(pwd)/youki

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Apr 6, 2023

Hey @kemkemG0 Thanks for this update! Can I ask you to also update the same in docs? (It is already updated there)

@codecov-commenter
Copy link

Codecov Report

Merging #1781 (122f4f2) into main (3827658) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   68.67%   68.68%           
=======================================
  Files         121      121           
  Lines       13318    13318           
=======================================
+ Hits         9146     9147    +1     
+ Misses       4172     4171    -1     

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YJDoc2 YJDoc2 merged commit b5fd65b into youki-dev:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants