Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI rules not filtering integration test files properly #1643

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

lengrongfu
Copy link
Collaborator

@lengrongfu lengrongfu commented Mar 8, 2023

fixes #1639

@lengrongfu
Copy link
Collaborator Author

What is the wrong job in this pipeline?

@yihuaf
Copy link
Collaborator

yihuaf commented Mar 9, 2023

What is the wrong job in this pipeline?

It timed out after 15 min. I kick it again and see what happens.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@yihuaf
Copy link
Collaborator

yihuaf commented Mar 9, 2023

@lengrongfu I believe your change is good additions, but doesn't fix the underlying issue. I just checked this change with another PR I have and it doesn't trigger with integration test file changes. I believe the correct fix is in the review. Please make the change and I can merge :)

@codecov-commenter
Copy link

Codecov Report

Merging #1643 (4bd1f57) into main (4303e4d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   68.96%   68.95%   -0.01%     
==========================================
  Files         120      120              
  Lines       13156    13156              
==========================================
- Hits         9073     9072       -1     
- Misses       4083     4084       +1     

@yihuaf
Copy link
Collaborator

yihuaf commented Mar 9, 2023

I apologize. I think I screwed up with directly merging the suggestions. The commits are not signed off. Feel free to override my commit with the suggested change and force push again...

@lengrongfu lengrongfu changed the title fix ci rule Draft: fix ci rule Mar 9, 2023
@lengrongfu
Copy link
Collaborator Author

lengrongfu commented Mar 9, 2023

I will run effective tests to make sure this problem is fixed before going from draft to official pr.

@yihuaf
Copy link
Collaborator

yihuaf commented Mar 9, 2023

I pass the test first, then review pr.

Can you elaborate what you mean?

@yihuaf yihuaf mentioned this pull request Mar 9, 2023
@yihuaf
Copy link
Collaborator

yihuaf commented Mar 9, 2023

I will run effective tests to make sure this problem is fixed before going from draft to official pr.

I mean sure :) But I already tested for you. You can just include my suggested change (squash the commits) and then I can approve.

@yihuaf yihuaf self-assigned this Mar 9, 2023
Signed-off-by: lengrongfu <[email protected]>
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@yihuaf yihuaf changed the title Draft: fix ci rule Fix CI rules not filtering integration test files properly Mar 9, 2023
@yihuaf yihuaf merged commit 84c0f5b into youki-dev:main Mar 9, 2023
@yihuaf yihuaf mentioned this pull request Mar 9, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

files under integration tests doesn't seem to trigger CI correctly.
3 participants