-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI rules not filtering integration test files properly #1643
Conversation
What is the wrong job in this pipeline? |
It timed out after 15 min. I kick it again and see what happens. |
@lengrongfu I believe your change is good additions, but doesn't fix the underlying issue. I just checked this change with another PR I have and it doesn't trigger with integration test file changes. I believe the correct fix is in the review. Please make the change and I can merge :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 68.96% 68.95% -0.01%
==========================================
Files 120 120
Lines 13156 13156
==========================================
- Hits 9073 9072 -1
- Misses 4083 4084 +1 |
I apologize. I think I screwed up with directly merging the suggestions. The commits are not signed off. Feel free to override my commit with the suggested change and force push again... |
I will run effective tests to make sure this problem is fixed before going from draft to official pr. |
Can you elaborate what you mean? |
I mean sure :) But I already tested for you. You can just include my suggested change (squash the commits) and then I can approve. |
Signed-off-by: lengrongfu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
fixes #1639