Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust 1.67 #1516

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Update to rust 1.67 #1516

merged 1 commit into from
Feb 2, 2023

Conversation

Furisto
Copy link
Collaborator

@Furisto Furisto commented Jan 27, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1516 (0836dbf) into main (fbd29f7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1516   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files         120      120           
  Lines       13094    13094           
=======================================
  Hits         8999     8999           
  Misses       4095     4095           

@Furisto Furisto force-pushed the rust-1.67 branch 3 times, most recently from 490ea7d to 2fa614a Compare January 27, 2023 23:12
@Furisto Furisto marked this pull request as draft January 27, 2023 23:14
@Furisto Furisto force-pushed the rust-1.67 branch 3 times, most recently from fe8c2a8 to 3de318c Compare January 28, 2023 15:34
Signed-off-by: Thomas Schubart <[email protected]>
@Furisto
Copy link
Collaborator Author

Furisto commented Jan 28, 2023

@utam0k The checks do not pass because it expects that integration tests run with 1.65.0. Looks like this is coming from branch protection rules: https://github.com/orgs/community/discussions/26698. I tried to configure the rules (see docs) but I do not see that option. Do you have permissions to change the rules?

@utam0k
Copy link
Member

utam0k commented Jan 31, 2023

@Furisto Sorry for the late! I updated.

@Furisto Furisto marked this pull request as ready for review February 1, 2023 19:23
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@YJDoc2 YJDoc2 merged commit ab60bfc into youki-dev:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants