Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix and refine documents #1351

Merged
merged 3 commits into from
Nov 20, 2022
Merged

Small fix and refine documents #1351

merged 3 commits into from
Nov 20, 2022

Conversation

udzura
Copy link
Contributor

@udzura udzura commented Nov 18, 2022

  • Change clone URL. Repository URLs with '[email protected]:...' seems to be for developers, who must have privileges to the youki repo.
  • Fix invalid link in basic usage 🙏

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 18, 2022

Thank you for fixing the link! Can I ask you to also update the url for runtime-tools to https as well?
Also git@... urls are not only for youki devs, but might fail is ssh keys of the user are not properly setup. We should change it to https anyways, might be helpful for others

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

@udzura
Copy link
Contributor Author

udzura commented Nov 18, 2022

@YJDoc2 Thanks for the review! Did you expect commit 463cdc4 ?

@codecov-commenter
Copy link

Codecov Report

Merging #1351 (463cdc4) into main (69b2cb3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   68.80%   68.80%           
=======================================
  Files         119      119           
  Lines       12586    12586           
=======================================
  Hits         8660     8660           
  Misses       3926     3926           

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 20, 2022

Thank you for your contribution :)

@YJDoc2 YJDoc2 merged commit 4a16a2e into youki-dev:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants