-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix and refine documents #1351
Conversation
udzura
commented
Nov 18, 2022
•
edited by gitpod-io
bot
Loading
edited by gitpod-io
bot
- Change clone URL. Repository URLs with '[email protected]:...' seems to be for developers, who must have privileges to the youki repo.
- Fix invalid link in basic usage 🙏
f936cd9
to
c174888
Compare
Signed-off-by: Uchio Kondo <[email protected]>
Signed-off-by: Uchio Kondo <[email protected]>
c174888
to
ecf2d02
Compare
Thank you for fixing the link! Can I ask you to also update the url for runtime-tools to https as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution!
Signed-off-by: Uchio Kondo <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
=======================================
Coverage 68.80% 68.80%
=======================================
Files 119 119
Lines 12586 12586
=======================================
Hits 8660 8660
Misses 3926 3926 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Thank you for your contribution :) |