Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestContainerKill required error message in kill command #1319

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Nov 6, 2022

This will pass the TestContainerKill of containerd

Fixes #1314

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #1319 (2f8a153) into main (184c21b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   68.76%   68.72%   -0.04%     
==========================================
  Files         119      119              
  Lines       12595    12602       +7     
==========================================
  Hits         8661     8661              
- Misses       3934     3941       +7     

@YJDoc2 YJDoc2 requested a review from utam0k November 6, 2022 12:03
@YJDoc2 YJDoc2 requested a review from utam0k November 6, 2022 12:46
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@utam0k utam0k merged commit d99b665 into youki-dev:main Nov 6, 2022
@YJDoc2 YJDoc2 deleted the fix_test_kill branch November 8, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass TestContainerKill containerd test
3 participants