Don't create a file when it already exists when mounting with bind (#…

…2031) For example, it is more likely that the /etc/hosts file already exists. In that case, it fails because it tries to open the file with write permission while it is RO. Signed-off-by: utam0k <[email protected]>
youki-dev · Jun 12, 2023 · f5f2242 · f5f2242
1 parent 3251599
commit f5f2242
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/crates/libcontainer/src/rootfs/mount.rs b/crates/libcontainer/src/rootfs/mount.rs
@@ -497,7 +497,7 @@ impl Mount {
                 err
             })?;
 
-            if src.is_file() {
+            if src.is_file() && !dest.exists() {
                 OpenOptions::new()
                     .create(true)
                     .write(true)

diff --git a/hack/debug.bt b/hack/debug.bt
@@ -78,8 +78,6 @@ tracepoint:syscalls:sys_enter_setresuid
     printf("ruid=%d, euid=%d, suid=%d\n", args->ruid, args->euid, args->suid);
 }
 
-
-
 END
 {
     clear(@filename);