Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: Menus disappears on Firefox when restarted #108

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

yorkxin
Copy link
Owner

@yorkxin yorkxin commented Sep 4, 2022

Solves #107

chrome.runtime.onInstalled is not called when Firefox restarted. This behavior is inconsistent with Chrome.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1567467

Followup explores: (not a release blocker)

  • Confirm behavior on Firefox MV3
  • Refactor code so that codes of menus creation are not copy-pasted.
  • Consider introducing custom menu lifecycle manager like uBlock?

Summary

Tests

  • Chrome stable (macOS)
  • Firefox stable (macOS)
  • Chrome stable (Windows)
  • Firefox stable (Windows)

Optional:

  • Chrome beta (macOS)
  • Firefox beta (macOS)
  • Chrome beta (Windows)
  • Firefox beta (Windows)

`chrome.runtime.onInstalled` is not called when Firefox restarted. This behavior is inconsistent with Chrome.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1567467
@yorkxin yorkxin marked this pull request as ready for review September 5, 2022 04:02
@yorkxin yorkxin force-pushed the firefox-menus-workaround branch from cd1e99a to 5b15b75 Compare September 5, 2022 04:03
should've be done at master
@yorkxin yorkxin force-pushed the firefox-menus-workaround branch from 5b15b75 to 24fc674 Compare September 5, 2022 04:03
@yorkxin yorkxin merged commit 8b6662a into master Sep 5, 2022
@yorkxin yorkxin deleted the firefox-menus-workaround branch September 5, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant