-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Project field to YorkieService logs #911
Conversation
Warning Review failedThe pull request is closed. WalkthroughThe changes focus on enhancing logging capabilities, interceptors, and unique request ID handling within the Yorkie server. Key changes include updating the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 50.72% 50.57% -0.15%
==========================================
Files 70 70
Lines 10479 10508 +29
==========================================
- Hits 5315 5314 -1
- Misses 4636 4666 +30
Partials 528 528 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
Add Project field to YorkieService logs
This commit adds
project
field to the YorkieService logs for easierproject identification during debugging. Additionally, removes
LoggingInterceptor to allow each service to define its own log fields,
as YorkieService and AdminService logs may differ.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
New Features
Improvements
Refactor
Documentation