Support yorkie-monitoring and yorkie-argocd Charts on NCP
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 70 70
Lines 10255 10255
=======================================
Hits 5211 5211
Misses 4516 4516
Partials 528 528 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for
yorkie-monitoringandyorkie-argocdcharts on NCP. Additionally, it addresses a small parsing error in the annotation ofalb.ingress.kubernetes.io/ssl-certificate-noby converting the value from number to string.Which issue(s) this PR fixes:
Fixes #844
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: