-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect calculation in indexTree.treePosToPath
operation
#824
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 50.71% 50.62% -0.10%
==========================================
Files 70 70
Lines 10213 10234 +21
==========================================
+ Hits 5180 5181 +1
- Misses 4512 4530 +18
- Partials 521 523 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I left simple comments.
Co-authored-by: Youngteac Hong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What this PR does / why we need it:
This patch addresses an issue arising from the
tree.edit
operation in response to problem with calculating thefromPath
when multipletreePos
represent a single index-based coordinate, leading to inaccuracies.This PR contains migration work for yorkie-team/yorkie-js-sdk#751, so detailed information can also be found there.
Which issue(s) this PR fixes:
Address #749
Related yorkie-team/yorkie-js-sdk#751
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: