Fix logic errors in TreeNode.DeepCopy #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 50.71% 50.81% +0.09%
==========================================
Files 70 70
Lines 10213 10226 +13
==========================================
+ Hits 5180 5196 +16
+ Misses 4512 4504 -8
- Partials 521 526 +5 ☔ View full report in Codecov by Sentry. |
raararaara
force-pushed
the
fix-missing-insprevId
branch
from
390e470 to
566957e
Compare
hackerwins
reviewed
Mar 18, 2024
hackerwins
changed the title
hackerwins
approved these changes
Mar 22, 2024
hackerwins
added a commit
that referenced
this pull request
Mar 22, 2024
This commit addresses the following logic errors in TreeNode.DeepCopy: 1. Missing insPrevID and insNextID - resolved in Fix errors when editing Tree due to missing insPrevID in CRDTTree yorkie-js-sdk#756 and ported accordingly. 2. Incorrect calculation of IndexTreeNode.Length - including tombstone nodes in length calculation. This commit fixes these issues, and corresponding test cases have been added. --------- Co-authored-by: Youngteac Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix logic errors in TreeNode.DeepCopy
This PR addresses the following logic errors in
TreeNode.DeepCopy:This commit fixes these issues, and corresponding test cases have been added.
Which issue(s) this PR fixes:
Address #754
Related to yorkie-team/yorkie-js-sdk#756
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: