Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Design Document for Missing Document Link and Instructon #782

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

krapie
Copy link
Member

@krapie krapie commented Feb 5, 2024

What this PR does / why we need it:

Update README.md in the design document for missing document links and ordering.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie added the documentation 📔 Improvements or additions to documentation label Feb 5, 2024
@krapie krapie requested a review from hackerwins February 5, 2024 10:11
@krapie krapie self-assigned this Feb 5, 2024
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 67b16a1 into main Feb 5, 2024
4 checks passed
@hackerwins hackerwins deleted the design-document-update branch February 5, 2024 10:31
@krapie
Copy link
Member Author

krapie commented Feb 5, 2024

@hackerwins Seems like CI has failed because test has been started before server startup.
Maybe we need to wait for test server to start before the test begins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📔 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants