Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary String() calls with stringer interface #777

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Jan 29, 2024

What this PR does / why we need it:
This PR removes unnecessary String() calls with stringer interface.
We hope this style to be applied to the overall code base to keep it simple.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@sejongk sejongk requested review from hackerwins and krapie January 29, 2024 04:22
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0a7f4c8) 50.71% compared to head (3ad01f0) 50.71%.

Files Patch % Lines
server/backend/sync/memory/pubsub.go 0.00% 9 Missing ⚠️
server/backend/database/memory/database.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   50.71%   50.71%           
=======================================
  Files          70       70           
  Lines       10213    10213           
=======================================
  Hits         5180     5180           
  Misses       4512     4512           
  Partials      521      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 0cdb329 into main Jan 29, 2024
4 checks passed
@hackerwins hackerwins deleted the remove-unnecessary-string-call branch January 29, 2024 05:58
Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants