Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor concurrency tests for basic Tree.Edit #772

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

justiceHui
Copy link
Member

@justiceHui justiceHui commented Jan 23, 2024

What this PR does / why we need it:

Refactored the concurrency test for Tree.Edit method for insert, delete, and replace operations.

Insert/Delete/Replace by 2 users (9 * 9 * 9 = 729 cases):

  • Ranges(9)
    • intersecting, element
    • intersecting, text
    • A contains B, element
    • A contains B, text
    • A contains B, A is element, B is text
    • side by side, element
    • side by side, text
    • A = B, element
    • A = B, text
  • Operations for both A and B(9)
    • Insert text front of range
    • Insert text middle of range
    • Insert text back of range
    • Replace to text node
    • Insert element front of range
    • Insert element middle of range
    • Insert element back of range
    • Replace to element node
    • Delete

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6651d42) 50.72% compared to head (deb1128) 50.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   50.72%   50.73%           
=======================================
  Files          70       70           
  Lines       10210    10234   +24     
=======================================
+ Hits         5179     5192   +13     
- Misses       4509     4517    +8     
- Partials      522      525    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins marked this pull request as ready for review January 25, 2024 04:01
@hackerwins hackerwins self-requested a review January 25, 2024 04:01
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins changed the title Refactoring tree concurrency test Refactor concurrency tests for basic Tree.Edit Jan 25, 2024
@hackerwins hackerwins merged commit 18a460f into main Jan 25, 2024
4 checks passed
@hackerwins hackerwins deleted the tree-concurrency-test branch January 25, 2024 04:11
hackerwins pushed a commit that referenced this pull request Jan 25, 2024
Insert/Delete/Replace by 2 users (9 * 9 * 9 = 729 cases):
  - Ranges(9)
    - intersecting, element
    - intersecting, text
    - A contains B, element
    - A contains B, text
    - A contains B, A is element, B is text
    - side by side, element
    - side by side, text
    - A = B, element
    - A = B, text
  - Operations for both A and B(9)
    - Insert text front of range
    - Insert text middle of range
    - Insert text back of range
    - Replace to text node
    - Insert element front of range
    - Insert element middle of range
    - Insert element back of range
    - Replace to element node
    - Delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants