-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce object creation interface with initial values #756
Conversation
…t TempCounter struct type and constructor The only way to create counter is using newCounter. To support nested element build, new struct type is needed to receive the argument to create a counter inside.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 49.35% 50.14% +0.79%
==========================================
Files 69 69
Lines 10113 10182 +69
==========================================
+ Hits 4991 5106 +115
+ Misses 4606 4534 -72
- Partials 516 542 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I've left some comments, please check them.
1. integrate text, counter, tree type interface 2. decouple the build json from buildCRDTElement 3. fix duplicated deregister 4. relevant testcode update
Add buildArrayMember Refactor NewArray, NewObject, buildCRDTElement, counter type test code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
What this PR does / why we need it:
There was no way to set nested object in one set operation.
So It needed multiple set operation.
To resolve this issues, this pr modify the set operation to create a nested object in one operation.
More details refer the follow link.
yorkie-team/yorkie-js-sdk#691 (comment)
Which issue(s) this PR fixes:
Fixes #663
Does this PR introduce a user-facing change?:
As-is
To-be
As-is
To be
Limitations
Checklist: