Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup proto #614

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Cleanup proto #614

merged 3 commits into from
Aug 18, 2023

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #498

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@chacha912 chacha912 requested a review from hackerwins August 18, 2023 07:28
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change from using bytes to strings for ClientID in APIs due to consistency reasons? (There seems to be no size problem because they are not included in documents.)

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #614 (76402cb) into main (b111ab1) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   50.24%   50.23%   -0.01%     
==========================================
  Files          69       69              
  Lines        7314     7305       -9     
==========================================
- Hits         3675     3670       -5     
+ Misses       3147     3145       -2     
+ Partials      492      490       -2     
Files Changed Coverage Δ
client/client.go 13.48% <11.11%> (ø)
server/rpc/yorkie_server.go 56.86% <91.66%> (+0.03%) ⬆️

@chacha912
Copy link
Contributor Author

@hackerwins Yes, your point is accurate. It would also reduce the need for frequent conversions between bytes and string during usage.

@hackerwins hackerwins merged commit cf74a80 into main Aug 18, 2023
@hackerwins hackerwins deleted the cleanup-proto branch August 18, 2023 08:44
Wu22e pushed a commit to Wu22e/yorkie that referenced this pull request Sep 3, 2023
* Remove unused client id(key) from API response

* Change clientID type from bytes to string in the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup protobuf response
2 participants