Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include-snapshot flag to ListDocuments API #575

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jul 4, 2023

What this PR does / why we need it:

Add include-snapshot flag to ListDocuments API

Which issue(s) this PR fixes:

Fixes #573

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #575 (590dba7) into main (ba89b2c) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   51.29%   51.50%   +0.20%     
==========================================
  Files          67       67              
  Lines        6960     6932      -28     
==========================================
  Hits         3570     3570              
+ Misses       2919     2891      -28     
  Partials      471      471              
Impacted Files Coverage Δ
server/rpc/admin_server.go 53.97% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

@hackerwins hackerwins marked this pull request as ready for review July 6, 2023 11:22
@hackerwins hackerwins merged commit 278452c into main Jul 6, 2023
@hackerwins hackerwins deleted the add-include-snapshot-flag branch July 6, 2023 11:23
hackerwins added a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add include-snapshot flag to ListDocuments API
2 participants