Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logout command to CLI #571

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Jul 3, 2023

What this PR does / why we need it: Add logout command to yorkie cli

Which issue(s) this PR fixes:

Fixes #488

Special notes for your reviewer:

Since yorkie login allows login to multiple servers, logout should also allow logout on a per-server basis. thus yorkie logout command would work as follows:

  • If the user is logged in to only one server
    • can log out with yorkie logout.
  • If the user is logged in to multiple servers
    • can log out from a specific server with yorkie logout --rpc-addr "<SERVER_ADDRESS>".
  • or log out from all servers with yorkie logout --force. (is --all is better name than --force?)

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx force-pushed the feat/cli-logout branch from 13b6bc8 to 5b6446e Compare July 3, 2023 13:36
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #571 (5b6446e) into main (3e34fc6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files          67       67           
  Lines        6949     6949           
=======================================
  Hits         3566     3566           
  Misses       2915     2915           
  Partials      468      468           

@hackerwins hackerwins self-requested a review July 3, 2023 21:13
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 39db60d into yorkie-team:main Jul 3, 2023
@hackerwins hackerwins changed the title feat: add logout command to cli Add logout command to CLI Jul 3, 2023
@blurfx blurfx deleted the feat/cli-logout branch July 4, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logout command to CLI
2 participants