Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum synced ticket in PushPull response #57

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

hackerwins
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


@hackerwins hackerwins added the wip label Jun 5, 2020
@hackerwins hackerwins force-pushed the feature/garbage-collection branch from 961c49a to 8c539b5 Compare June 5, 2020 05:24
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #57 into master will decrease coverage by 0.46%.
The diff coverage is 39.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   55.71%   55.25%   -0.47%     
==========================================
  Files          23       23              
  Lines        2554     2579      +25     
==========================================
+ Hits         1423     1425       +2     
- Misses       1038     1058      +20     
- Partials       93       96       +3     
Impacted Files Coverage Δ
pkg/document/json/rht_pq_map.go 52.17% <0.00%> (-1.16%) ⬇️
pkg/document/json/root.go 15.51% <8.33%> (-3.54%) ⬇️
pkg/document/document.go 43.67% <66.66%> (+0.82%) ⬆️
api/converter/from_pb.go 81.38% <100.00%> (+0.09%) ⬆️
api/converter/to_pb.go 81.17% <100.00%> (+0.11%) ⬆️
pkg/document/internal_document.go 22.78% <100.00%> (+2.00%) ⬆️
pkg/llrb/llrb.go 73.46% <0.00%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62722d...c37e161. Read the comment docs.

@hackerwins hackerwins force-pushed the feature/garbage-collection branch 4 times, most recently from 452f047 to bc13c10 Compare June 6, 2020 02:27
@hackerwins hackerwins force-pushed the feature/garbage-collection branch from bc13c10 to c37e161 Compare June 6, 2020 02:35
@hackerwins hackerwins merged commit 0597a62 into master Jun 6, 2020
@hackerwins hackerwins deleted the feature/garbage-collection branch June 6, 2020 02:43
@hackerwins hackerwins restored the feature/garbage-collection branch June 6, 2020 14:05
@hackerwins hackerwins deleted the feature/garbage-collection branch June 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garbage collection
1 participant