Filter out removed documents from ListDocuments API #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hackerwins
force-pushed
the
filter-out-removed-documents
branch
2 times, most recently
from
6116e17 to
99ce519
Compare
hackerwins
force-pushed
the
filter-out-removed-documents
branch
from
99ce519 to
a2cc85d
Compare
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 52.25% 52.27% +0.02%
==========================================
Files 67 67
Lines 6794 6797 +3
==========================================
+ Hits 3550 3553 +3
Misses 2806 2806
Partials 438 438
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Filter out removed documents from ListDocuments API
Previously, removed documents were exposed in the document list of CLI or Dashboard.
This commit ensures that removed documents are removed from the list, making it appears as if they are properly removed.
Which issue(s) this PR fixes:
Related to #464
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: