Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change k8s version of yorkie-cluster chart to 1.23 #550

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

emplam27
Copy link
Contributor

What this PR does / why we need it:

  • Modify yorkie-cluster helm chart k8s version (1.24 => 1.23)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@emplam27 emplam27 self-assigned this Jun 16, 2023
@hackerwins hackerwins requested a review from krapie June 16, 2023 06:39
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #550 (9ea3a20) into main (17b5954) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   50.53%   50.43%   -0.11%     
==========================================
  Files          67       67              
  Lines        6678     6763      +85     
==========================================
+ Hits         3375     3411      +36     
- Misses       2876     2923      +47     
- Partials      427      429       +2     

see 6 files with indirect coverage changes

Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get an explanation of why this change is needed?

@emplam27
Copy link
Contributor Author

emplam27 commented Jun 19, 2023

Can I get an explanation of why this change is needed?

@krapie
we want to use 'n3r Dedicated Cluster' to deploy yorkie with the same helm configuration in naver internal environment.
1.23 version is required to use n3r Dedicated Cluster.

@krapie krapie self-requested a review June 19, 2023 06:30
Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emplam27
I have looked up for changes between v1.24 and v1.23 with Istio 1.17 compatibility, and also tested yorkie cluster on v1.23 environment.

It seems okay to downgrade K8s version to v1.23.

@hackerwins hackerwins merged commit c081d24 into main Jun 19, 2023
@hackerwins hackerwins deleted the yorkie-chart-k8s-version branch June 19, 2023 07:42
@hackerwins
Copy link
Member

@krapie Thank you for checking compatibility.

@hackerwins hackerwins changed the title Modify yorkie-cluster helm chart k8s version (1.24 => 1.23) Change k8s version of yorkie-cluster chart to 1.23 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants