Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tree.Style for setting attributes to nodes #549

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jun 14, 2023

What this PR does / why we need it:

Implement Tree.Style for setting attributes to nodes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins changed the title Add TreeNode.attributes initialization Implement Tree.Style for setting attributes to nodes Jun 14, 2023
@hackerwins hackerwins marked this pull request as ready for review June 14, 2023 09:56
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #549 (c32193b) into main (0ce364b) will decrease coverage by 0.11%.
The diff coverage is 46.87%.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   50.53%   50.43%   -0.11%     
==========================================
  Files          67       67              
  Lines        6678     6763      +85     
==========================================
+ Hits         3375     3411      +36     
- Misses       2876     2923      +47     
- Partials      427      429       +2     
Impacted Files Coverage Δ
api/converter/to_pb.go 57.27% <0.00%> (-1.98%) ⬇️
pkg/index/tree.go 53.18% <0.00%> (ø)
api/converter/from_pb.go 49.23% <7.40%> (-2.30%) ⬇️
api/converter/to_bytes.go 72.29% <64.28%> (-2.18%) ⬇️
pkg/document/crdt/tree.go 72.29% <70.96%> (-0.12%) ⬇️
pkg/document/crdt/rht.go 68.25% <100.00%> (+7.46%) ⬆️

@krapie krapie force-pushed the treenode-attributes branch from ff1e67c to c32193b Compare June 14, 2023 11:18
@hackerwins hackerwins merged commit fade761 into main Jun 15, 2023
@hackerwins hackerwins deleted the treenode-attributes branch June 15, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants