Add TLS Option & Insecure Flag in Admin CLI #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #548 +/- ##
=======================================
Coverage 50.53% 50.53%
=======================================
Files 67 67
Lines 6678 6678
=======================================
Hits 3375 3375
Misses 2876 2876
Partials 427 427 |
hackerwins
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks for your contribution. Overall, it looks good.
After this PR, referring to ArgoCD CLI might be helpful for Yorkie CLI. For instance, it would be beneficial to change the Login command to receive the address as an argument instead of a flag, similar to how it is done in the ArgoCD CLI, and store it in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add TLS option & insecure flag in admin CLI.
This is to set TLS connectivity between hosted server (
api.yorkie.dev) and admin CLI.Also,
--insecureglobal flag is added to disable the TLS connection of the client when needed.Which issue(s) this PR fixes:
Fixes https://github.com/yorkie-team/devops/issues/43
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: