Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove document command to CLI #540

Merged
merged 13 commits into from
May 23, 2023
Merged

Conversation

emplam27
Copy link
Contributor

What this PR does / why we need it:

Add RemoveDocumentAdmin API in Admin client & CLI command

  • dashboard can use gRPC API for remove document
  • User can use CLI command for remove document

Which issue(s) this PR fixes:

Fixes #464

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

$ yorkie document remove {project name} {document key}

Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins changed the title Remove document cli small Add remove document command to CLI May 23, 2023
@hackerwins hackerwins force-pushed the remove-document-cli-small branch from cd9981c to 44bf7c2 Compare May 23, 2023 09:25
@hackerwins hackerwins force-pushed the remove-document-cli-small branch from 44bf7c2 to 2ab0245 Compare May 23, 2023 09:31
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #540 (9dd9211) into main (ff4d8cc) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

❗ Current head 9dd9211 differs from pull request most recent head a531ed1. Consider uploading reports for the commit a531ed1 to get more accurate results

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   50.92%   50.32%   -0.60%     
==========================================
  Files          65       65              
  Lines        5978     6057      +79     
==========================================
+ Hits         3044     3048       +4     
- Misses       2539     2614      +75     
  Partials      395      395              
Impacted Files Coverage Δ
server/backend/database/memory/database.go 51.13% <0.00%> (-1.44%) ⬇️
server/backend/database/mongo/client.go 24.11% <0.00%> (-0.80%) ⬇️
server/backend/database/mongo/indexes.go 50.00% <ø> (ø)
server/rpc/admin_server.go 53.78% <0.00%> (-8.36%) ⬇️

... and 2 files with indirect coverage changes

@hackerwins hackerwins self-requested a review May 23, 2023 12:04
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
We can remove documents with CLI.

@hackerwins hackerwins merged commit 8287e05 into main May 23, 2023
@hackerwins hackerwins deleted the remove-document-cli-small branch May 23, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement document deletion
2 participants