Resolve Helm Chart Installation Fail on Custom Release Name #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 50.37% 50.37%
=======================================
Files 64 64
Lines 5779 5779
=======================================
Hits 2911 2911
Misses 2490 2490
Partials 378 378 |
hackerwins
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resolve Helm chart installation fail on custom release name.
This was due to resource name conflict between Helm subcharts (
prometheus-community/kube-prometheus-stack&grafana/grafana).Therefore,
fullnameOverridefield has been manually configured to resolve resource name conflict. This will soon be refactored by Helm's_helper.tplfor dynamically setting Helm template values.Which issue(s) this PR fixes:
Fixes #528
Special notes for your reviewer:
Since Helm chart version is not changed, Helm chart releaser action will not create new Helm chart which contains new revisions including this PR.
So I will manually rebuild Helm charts in packages (by deleting 0.3.4 version Helm charts and re-run Helm chart releaser action).
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: