Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic and wrapping informational error from server #519

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

emplam27
Copy link
Contributor

What this PR does / why we need it:

Sub PR for #501

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@emplam27 emplam27 marked this pull request as ready for review April 21, 2023 01:58
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #519 (e4fe946) into main (efe3e87) will increase coverage by 0.39%.
The diff coverage is 31.00%.

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   50.22%   50.61%   +0.39%     
==========================================
  Files          64       64              
  Lines        5671     5751      +80     
==========================================
+ Hits         2848     2911      +63     
+ Misses       2481     2471      -10     
- Partials      342      369      +27     
Impacted Files Coverage Δ
server/backend/config.go 55.55% <0.00%> (-5.43%) ⬇️
server/backend/database/mongo/config.go 73.91% <0.00%> (-7.04%) ⬇️
internal/validation/validation.go 44.80% <30.76%> (-15.88%) ⬇️
api/types/create_project_fields.go 41.66% <45.45%> (-41.67%) ⬇️
api/types/updatable_project_fields.go 60.00% <50.00%> (-40.00%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins self-requested a review April 21, 2023 02:26
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 969e509 into main Apr 21, 2023
@hackerwins hackerwins deleted the remove-panic-server branch April 21, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants