-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the pushOnly flag of the pushpull API #500
Conversation
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 50.43% 50.31% -0.12%
==========================================
Files 64 64
Lines 5645 5660 +15
==========================================
+ Hits 2847 2848 +1
- Misses 2457 2470 +13
- Partials 341 342 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
18bb752
to
5532b66
Compare
5532b66
to
7347095
Compare
a5c9cdf
to
dfd4404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Even though it was the first PR, the operation was a bit complicated, but thank you for working on it.
When push-only is set to true, the Server will respond with an empty operations unless there have been actual changes to the data. In cases where the push-pull response contains changes that have already been made on the client side, empty changes will be sent to prevent redoing those operations. Due to these modifications, deep copying of changeInfo is required. --------- Co-authored-by: Youngteac Hong <[email protected]>
When push-only is set to true, the Server will respond with an empty operations unless there have been actual changes to the data. In cases where the push-pull response contains changes that have already been made on the client side, empty changes will be sent to prevent redoing those operations. Due to these modifications, deep copying of changeInfo is required. --------- Co-authored-by: Youngteac Hong <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #482 (Server side only)
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: