Add user agent metrics #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add metric about yorkie-sdk-type/version, projectID/Name, server instance name etc. - every grpc request success, collect metric about yorkie-sdk information
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 48.68% 48.33% -0.35%
==========================================
Files 69 69
Lines 5953 5896 -57
==========================================
- Hits 2898 2850 -48
+ Misses 2714 2705 -9
Partials 341 341
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hackerwins
force-pushed
the
yorkie-sdk-metrics
branch
from
294f235 to
23732c5
Compare
- 1. Move collecting user-agent metrics to interceptors - 2. Remove gRPC dependency from metrics - 3. Extract header constants
hackerwins
force-pushed
the
yorkie-sdk-metrics
branch
from
23732c5 to
ad2deb6
Compare
hackerwins
approved these changes
Mar 22, 2023
krapie
reviewed
Apr 24, 2023
| return nil, fmt.Errorf("get hostname: %w", err) | ||
| hostname := conf.Hostname | ||
| if hostname == "" { | ||
| hostname, err := os.Hostname() |
There was a problem hiding this comment.
This hostname value inside if statement shadows hostname in line 68.
Therefore hostname will not be updated.
I'll fix this in #521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
yorkie-js-sdk,yorkie-ios-sdk,yorkie-android-sdkneed to set header and put yorkie-sdk informationshostnamewhen the server start (hostname is used in metrics etc.)$ yorkie server ... --hostname {host name value} ...Backend.Hostnamefield valueWhich issue(s) this PR fixes:
Fixes #393
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: