-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out unsubscribed documents key in DocEvent #463
Conversation
Codecov Report
@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 46.56% 46.60% +0.03%
==========================================
Files 70 70
Lines 5723 5727 +4
==========================================
+ Hits 2665 2669 +4
Misses 2764 2764
Partials 294 294
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
As we discussed, I think it would be nice to add test code like below.
|
@hackerwins Thank you for suggesting a testing procedure.
In the original logic, an error occurs at step 4, but the test is passed after modification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I left a trivial comment.
What this PR does / why we need it:
When firing a DocEvent, instead of directly passing the documentKeys of the published event,
it is passed to the subscribed documentKey.
Previously, an error occurred in the following code when a client that only subscribed to
docKey1
received a documentKeys of [
docKey1
,docKey2
].Which issue(s) this PR fixes:
Address yorkie-team/yorkie-js-sdk#455
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: