Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CRDT Counter in local change #449

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Increase CRDT Counter in local change #449

merged 1 commit into from
Jan 25, 2023

Conversation

cozitive
Copy link
Contributor

@cozitive cozitive commented Jan 25, 2023

What this PR does / why we need it:
When changing value of Counter through calling increase(), local value in Document.doc is not updated. The problem was hidden because Document.clone and remote value has been updated normally.

Which issue(s) this PR fixes:

Address yorkie-team/yorkie-js-sdk#438

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #449 (e901127) into main (121b337) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   46.48%   46.47%   -0.01%     
==========================================
  Files          70       70              
  Lines        5731     5730       -1     
==========================================
- Hits         2664     2663       -1     
  Misses       2773     2773              
  Partials      294      294              
Impacted Files Coverage Δ
api/converter/from_pb.go 54.92% <0.00%> (-0.22%) ⬇️
api/converter/to_bytes.go 83.33% <0.00%> (-0.16%) ⬇️
pkg/document/crdt/text.go 60.20% <0.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins self-requested a review January 25, 2023 08:37
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit 00cf588 into main Jan 25, 2023
@hackerwins hackerwins deleted the counter branch January 25, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants