Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Text and RichText #438

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Merge Text and RichText #438

merged 1 commit into from
Jan 12, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jan 5, 2023

What this PR does / why we need it:

Merge Text and RichText

Which issue(s) this PR fixes:

Address #435

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins force-pushed the cleanup-text branch 2 times, most recently from 27d75da to 44145aa Compare January 5, 2023 06:48
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #438 (de089ac) into main (7f7ea60) will decrease coverage by 0.63%.
The diff coverage is 75.43%.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   46.96%   46.32%   -0.64%     
==========================================
  Files          71       70       -1     
  Lines        5913     5735     -178     
==========================================
- Hits         2777     2657     -120     
+ Misses       2831     2783      -48     
+ Partials      305      295      -10     
Impacted Files Coverage Δ
pkg/document/crdt/rga_tree_split.go 73.50% <ø> (-0.25%) ⬇️
pkg/document/crdt/text.go 59.37% <67.44%> (+10.93%) ⬆️
api/converter/from_bytes.go 64.41% <100.00%> (-0.01%) ⬇️
api/converter/from_pb.go 54.77% <100.00%> (-0.83%) ⬇️
api/converter/to_bytes.go 83.48% <100.00%> (-2.35%) ⬇️
api/converter/to_pb.go 63.90% <100.00%> (-1.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins force-pushed the cleanup-text branch 2 times, most recently from e7f26c6 to 4004c83 Compare January 5, 2023 07:18
@hackerwins hackerwins added the protocol changed 📝 Whether the protocol has changed label Jan 10, 2023
@hackerwins hackerwins merged commit 6309915 into main Jan 12, 2023
@hackerwins hackerwins deleted the cleanup-text branch January 12, 2023 02:05
hackerwins added a commit that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant