Remove use of bou.ke/monkey library #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 71 71
Lines 5930 5930
=======================================
Hits 2779 2779
Misses 2846 2846
Partials 305 305 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for your PR. However, I am concerned because the structure of the test code seems to add complexity to the original code. 🤔 |
|
Thanks for your comment. As you mentioned, this method seems to increase the complexity of the original code for testing. I'll have to work on using other monkey patch libraries. |
chromato99
force-pushed
the
replace-monkeypatch
branch
from
c1b4509 to
7f9434e
Compare
|
I changed it to use the undefinedlabs/go-mpatch library instead of the above method. |
hackerwins
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove use of bou.ke/monkey library.
Recently there was an issue pointing to the license of the monkey patch library.
I looked for several ways to replace it, but other monkey patch libraries have the same problem that there are too few users and can not used in the arm architecture.
So, I thought about changing it in a way that avoids the need for a monkey patch, and I tried it.
But, this method may be considered unclean.
I'd appreciate it if you could comment on what I've been working on
Edit:
I changed it to use the undefinedlabs/go-mpatch library instead of the above method.
Same problem not working on ARM architecture, but I was able to completely replace the bou.ke/monkey library.
Which issue(s) this PR fixes:
Fixes #416
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: