-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version (1.16) #161
Conversation
We recommend using go1.16
io/ioutil is deprecated from go1.16
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 57.48% 58.75% +1.26%
==========================================
Files 37 37
Lines 3262 3280 +18
==========================================
+ Hits 1875 1927 +52
+ Misses 1202 1166 -36
- Partials 185 187 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackerwins That's a good point! But before proceeding with the update, I would like to make a suggestion. |
@dc7303 |
@hackerwins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Since `ioutil` is deprecated, so use `io.ReadAll`. https://golang.org/doc/go1.16#ioutil
What this PR does / why we need it:
We recommend the latest version of
Go
, so we will update it.Which issue(s) this PR fixes:
Fixes #157
Special notes for your reviewer:
Since
ioutil
is deprecated, I modified the code that uses that package.https://golang.org/doc/go1.16#ioutil
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: