Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version (1.16) #161

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Update go version (1.16) #161

merged 4 commits into from
Mar 15, 2021

Conversation

dc7303
Copy link
Member

@dc7303 dc7303 commented Mar 14, 2021

What this PR does / why we need it:
We recommend the latest version of Go, so we will update it.

Which issue(s) this PR fixes:

Fixes #157

Special notes for your reviewer:
Since ioutil is deprecated, I modified the code that uses that package.
https://golang.org/doc/go1.16#ioutil

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

dc7303 added 2 commits March 14, 2021 15:41
We recommend using go1.16
io/ioutil is deprecated from go1.16
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #161 (9f810d1) into main (b24df02) will increase coverage by 1.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   57.48%   58.75%   +1.26%     
==========================================
  Files          37       37              
  Lines        3262     3280      +18     
==========================================
+ Hits         1875     1927      +52     
+ Misses       1202     1166      -36     
- Partials      185      187       +2     
Impacted Files Coverage Δ
yorkie/config.go 81.25% <100.00%> (ø)
api/converter/from_pb.go 67.10% <0.00%> (-0.19%) ⬇️
api/converter/to_pb.go 85.65% <0.00%> (+0.11%) ⬆️
pkg/document/json/primitive.go 62.79% <0.00%> (+34.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24df02...9f810d1. Read the comment docs.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dc7303 Thanks for the contribution. I have a question.
Do we have to update Go version in README.md?

@hackerwins hackerwins assigned dc7303 and unassigned hackerwins Mar 14, 2021
@dc7303
Copy link
Member Author

dc7303 commented Mar 14, 2021

@hackerwins That's a good point!
We need 1.16 or higher as we change ioutil to io package. So, REAMDE.md update is also required.

But before proceeding with the update, I would like to make a suggestion.
Since the minimum go version is specified in go.mod, how about removing the go version information from REAMDE.md?

@dc7303 dc7303 assigned hackerwins and unassigned dc7303 Mar 14, 2021
@hackerwins
Copy link
Member

@dc7303
Thanks for the comments. I think you gave me a suggestion because of the idea that it is redundant.
However, I think it's okay to specify the version as it is easy for new developers to get started. If it's still a problem the next time the Go version is updated, it might be okay to remove it.

@dc7303
Copy link
Member Author

dc7303 commented Mar 15, 2021

@hackerwins
Thanks for your good opinion! 😄
The README.md has been updated, and the configuration files in workflows have also been updated.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hackerwins hackerwins merged commit 5771ce7 into main Mar 15, 2021
@hackerwins hackerwins deleted the update-go-version branch March 15, 2021 14:30
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
@chromato99 chromato99 mentioned this pull request Oct 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to version Go 1.16
2 participants