Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate DocChangedEvents in the batch #1173

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hackerwins
Copy link
Member

What this PR does / why we need it:

Prevent duplicate DocChangedEvents in the batch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Addressed and resolved all CodeRabbit review comments
  • Didn't break anything

Copy link

coderabbitai bot commented Feb 28, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@hackerwins-yorkie hackerwins-yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark Analysis 📊

This is a comparison result between the previous(c7797cf) and the current commit(b1ec942).

Significant Changes (≥20% difference)

Benchmark suite Previous Current Change
BenchmarkRPC/client_to_client_via_server/ (ns/op) 771.40 ms 481.50 ms 🟢 -37.58%
BenchmarkRPC/client_to_client_via_server/ (B/op) 39.09 MB 24.57 MB 🟢 -37.15%
BenchmarkRPC/client_to_client_via_server/ (allocs/op) 470,568 allocs 346,888 allocs 🟢 -26.28%
BenchmarkDocument/status_test/ (ns/op) 1334.00 ns 1067.00 ns 🟢 -20.01%

Key Observations 🔍

  • The BenchmarkRPC suite showed significant improvements in the client_to_client_via_server benchmarks, with a remarkable decrease in execution time, memory usage, and allocations. The client_to_client_via_server benchmarks saw reductions of approximately 37% in execution time, memory, and allocations, indicating substantial performance enhancements.
  • In the BenchmarkDocument suite, the status_test benchmark demonstrated a 20% decrease in execution time, showcasing improved efficiency in the status related operations.
  • Overall, the majority of benchmarks across different suites showed either minor improvements or remained relatively stable in terms of performance metrics. Notable decreases were observed in various benchmarks for different suites, indicating positive optimizations in processing times, memory usage, and allocation efficiency.

Detailed Test Results

BenchmarkDocument
Benchmark suite Previous Current Change
constructor_test/ (ns/op) 1472.00 ns 1474.00 ns 🔴 +0.14%
constructor_test/ (B/op) 1.43 KB 1.43 KB ⚪ 0%
constructor_test/ (allocs/op) 25 allocs 25 allocs ⚪ 0%
status_test/ (ns/op) 1334.00 ns 1067.00 ns 🟢 -20.01%
status_test/ (B/op) 1.40 KB 1.40 KB ⚪ 0%
status_test/ (allocs/op) 23 allocs 23 allocs ⚪ 0%
equals_test/ (ns/op) 7938.00 ns 7863.00 ns 🟢 -0.94%
equals_test/ (B/op) 7.71 KB 7.71 KB ⚪ 0%
equals_test/ (allocs/op) 132 allocs 132 allocs ⚪ 0%
nested_update_test/ (ns/op) 17081.00 ns 17042.00 ns 🟢 -0.23%
nested_update_test/ (B/op) 12.36 KB 12.36 KB ⚪ 0%
nested_update_test/ (allocs/op) 259 allocs 259 allocs ⚪ 0%
delete_test/ (ns/op) 22790.00 ns 22783.00 ns 🟢 -0.03%
delete_test/ (B/op) 15.84 KB 15.84 KB ⚪ 0%
delete_test/ (allocs/op) 340 allocs 340 allocs ⚪ 0%
object_test/ (ns/op) 8539.00 ns 8530.00 ns 🟢 -0.11%
object_test/ (B/op) 7.08 KB 7.08 KB 🔴 +0.01%
object_test/ (allocs/op) 119 allocs 119 allocs ⚪ 0%
array_test/ (ns/op) 28405.00 ns 31877.00 ns 🔴 +12.22%
array_test/ (B/op) 12.19 KB 12.19 KB ⚪ 0%
array_test/ (allocs/op) 274 allocs 274 allocs ⚪ 0%
text_test/ (ns/op) 31656.00 ns 32601.00 ns 🔴 +2.99%
text_test/ (B/op) 15.24 KB 15.24 KB ⚪ 0%
text_test/ (allocs/op) 485 allocs 485 allocs ⚪ 0%
text_composition_test/ (ns/op) 31389.00 ns 31556.00 ns 🔴 +0.53%
text_composition_test/ (B/op) 18.75 KB 18.75 KB ⚪ 0%
text_composition_test/ (allocs/op) 502 allocs 502 allocs ⚪ 0%
rich_text_test/ (ns/op) 86962.00 ns 84649.00 ns 🟢 -2.66%
rich_text_test/ (B/op) 39.41 KB 39.40 KB ⚪ 0%
rich_text_test/ (allocs/op) 1,147 allocs 1,147 allocs ⚪ 0%
counter_test/ (ns/op) 18075.00 ns 18249.00 ns 🔴 +0.96%
counter_test/ (B/op) 11.86 KB 11.86 KB ⚪ 0%
counter_test/ (allocs/op) 254 allocs 254 allocs ⚪ 0%
text_edit_gc_100/ (ns/op) 1.38 ms 1.37 ms 🟢 -0.80%
text_edit_gc_100/ (B/op) 864.90 KB 865.00 KB 🔴 +0.01%
text_edit_gc_100/ (allocs/op) 17,282 allocs 17,283 allocs ⚪ 0%
text_edit_gc_1000/ (ns/op) 52.51 ms 52.19 ms 🟢 -0.61%
text_edit_gc_1000/ (B/op) 46.84 MB 46.84 MB ⚪ 0%
text_edit_gc_1000/ (allocs/op) 185,593 allocs 185,599 allocs ⚪ 0%
text_split_gc_100/ (ns/op) 2.09 ms 2.07 ms 🟢 -1.23%
text_split_gc_100/ (B/op) 1.58 MB 1.58 MB ⚪ 0%
text_split_gc_100/ (allocs/op) 15,952 allocs 15,952 allocs ⚪ 0%
text_split_gc_1000/ (ns/op) 127.97 ms 128.60 ms 🔴 +0.49%
text_split_gc_1000/ (B/op) 137.79 MB 137.79 MB ⚪ 0%
text_split_gc_1000/ (allocs/op) 184,998 allocs 184,990 allocs ⚪ 0%
text_delete_all_10000/ (ns/op) 16.81 ms 17.29 ms 🔴 +2.85%
text_delete_all_10000/ (B/op) 10.58 MB 10.58 MB 🔴 +0.01%
text_delete_all_10000/ (allocs/op) 56,138 allocs 56,139 allocs ⚪ 0%
text_delete_all_100000/ (ns/op) 290.19 ms 265.14 ms 🟢 -8.63%
text_delete_all_100000/ (B/op) 105.54 MB 105.52 MB 🟢 -0.02%
text_delete_all_100000/ (allocs/op) 566,122 allocs 566,057 allocs 🟢 -0.01%
text_100/ (ns/op) 228221.00 ns 240069.00 ns 🔴 +5.19%
text_100/ (B/op) 120.95 KB 120.99 KB 🔴 +0.03%
text_100/ (allocs/op) 5,182 allocs 5,182 allocs ⚪ 0%
text_1000/ (ns/op) 2.43 ms 2.50 ms 🔴 +2.96%
text_1000/ (B/op) 1.16 MB 1.16 MB ⚪ 0%
text_1000/ (allocs/op) 51,085 allocs 51,085 allocs ⚪ 0%
array_1000/ (ns/op) 1.24 ms 1.27 ms 🔴 +2.99%
array_1000/ (B/op) 1.09 MB 1.09 MB 🔴 +0.02%
array_1000/ (allocs/op) 11,880 allocs 11,880 allocs ⚪ 0%
array_10000/ (ns/op) 13.36 ms 13.54 ms 🔴 +1.38%
array_10000/ (B/op) 9.89 MB 9.89 MB 🟢 -0.01%
array_10000/ (allocs/op) 120,736 allocs 120,730 allocs ⚪ 0%
array_gc_100/ (ns/op) 131033.00 ns 136677.00 ns 🔴 +4.31%
array_gc_100/ (B/op) 99.93 KB 99.93 KB ⚪ 0%
array_gc_100/ (allocs/op) 1,267 allocs 1,267 allocs ⚪ 0%
array_gc_1000/ (ns/op) 1.41 ms 1.46 ms 🔴 +3.52%
array_gc_1000/ (B/op) 1.14 MB 1.14 MB ⚪ 0%
array_gc_1000/ (allocs/op) 12,927 allocs 12,927 allocs ⚪ 0%
counter_1000/ (ns/op) 199973.00 ns 211508.00 ns 🔴 +5.77%
counter_1000/ (B/op) 178.18 KB 178.18 KB ⚪ 0%
counter_1000/ (allocs/op) 5,772 allocs 5,772 allocs ⚪ 0%
counter_10000/ (ns/op) 2.14 ms 2.19 ms 🔴 +2.44%
counter_10000/ (B/op) 2.07 MB 2.07 MB ⚪ 0%
counter_10000/ (allocs/op) 59,779 allocs 59,779 allocs ⚪ 0%
object_1000/ (ns/op) 1.41 ms 1.46 ms 🔴 +3.44%
object_1000/ (B/op) 1.44 MB 1.44 MB ⚪ 0%
object_1000/ (allocs/op) 9,926 allocs 9,926 allocs ⚪ 0%
object_10000/ (ns/op) 14.97 ms 14.60 ms 🟢 -2.46%
object_10000/ (B/op) 12.35 MB 12.35 MB ⚪ 0%
object_10000/ (allocs/op) 101,232 allocs 101,233 allocs ⚪ 0%
tree_100/ (ns/op) 1.04 ms 1.07 ms 🔴 +3.58%
tree_100/ (B/op) 951.08 KB 951.08 KB ⚪ 0%
tree_100/ (allocs/op) 6,103 allocs 6,103 allocs ⚪ 0%
tree_1000/ (ns/op) 74.45 ms 79.33 ms 🔴 +6.56%
tree_1000/ (B/op) 86.58 MB 86.58 MB ⚪ 0%
tree_1000/ (allocs/op) 60,113 allocs 60,112 allocs ⚪ 0%
tree_10000/ (ns/op) 9.39 s 9.59 s 🔴 +2.18%
tree_10000/ (B/op) 8.58 GB 8.58 GB ⚪ 0%
tree_10000/ (allocs/op) 600,205 allocs 600,196 allocs ⚪ 0%
tree_delete_all_1000/ (ns/op) 77.01 ms 79.71 ms 🔴 +3.50%
tree_delete_all_1000/ (B/op) 87.57 MB 87.57 MB ⚪ 0%
tree_delete_all_1000/ (allocs/op) 75,291 allocs 75,291 allocs ⚪ 0%
tree_edit_gc_100/ (ns/op) 3.83 ms 3.97 ms 🔴 +3.63%
tree_edit_gc_100/ (B/op) 4.15 MB 4.15 MB ⚪ 0%
tree_edit_gc_100/ (allocs/op) 15,147 allocs 15,147 allocs ⚪ 0%
tree_edit_gc_1000/ (ns/op) 314.96 ms 326.53 ms 🔴 +3.67%
tree_edit_gc_1000/ (B/op) 384.04 MB 384.04 MB ⚪ 0%
tree_edit_gc_1000/ (allocs/op) 154,937 allocs 154,941 allocs ⚪ 0%
tree_split_gc_100/ (ns/op) 2.59 ms 2.75 ms 🔴 +5.93%
tree_split_gc_100/ (B/op) 2.41 MB 2.41 MB ⚪ 0%
tree_split_gc_100/ (allocs/op) 11,132 allocs 11,132 allocs ⚪ 0%
tree_split_gc_1000/ (ns/op) 189.14 ms 204.27 ms 🔴 +8.00%
tree_split_gc_1000/ (B/op) 222.50 MB 222.50 MB ⚪ 0%
tree_split_gc_1000/ (allocs/op) 122,064 allocs 122,078 allocs 🔴 +0.01%
BenchmarkRPC
Benchmark suite Previous Current Change
client_to_server/ (ns/op) 420.53 ms 414.48 ms 🟢 -1.44%
client_to_server/ (B/op) 17.87 MB 16.13 MB 🟢 -9.71%
client_to_server/ (allocs/op) 223,725 allocs 223,543 allocs 🟢 -0.08%
client_to_client_via_server/ (ns/op) 771.40 ms 481.50 ms 🟢 -37.58%
client_to_client_via_server/ (B/op) 39.09 MB 24.57 MB 🟢 -37.15%
client_to_client_via_server/ (allocs/op) 470,568 allocs 346,888 allocs 🟢 -26.28%
attach_large_document/ (ns/op) 1.26 s 1.29 s 🔴 +2.43%
attach_large_document/ (B/op) 1.90 GB 1.89 GB 🟢 -0.64%
attach_large_document/ (allocs/op) 12,439 allocs 12,118 allocs 🟢 -2.58%
adminCli_to_server/ (ns/op) 543.02 ms 537.10 ms 🟢 -1.09%
adminCli_to_server/ (B/op) 21.30 MB 21.31 MB 🔴 +0.02%
adminCli_to_server/ (allocs/op) 316,652 allocs 316,679 allocs ⚪ 0%
BenchmarkLocker
Benchmark suite Previous Current Change
(ns/op) 85.81 ns 79.81 ns 🟢 -6.99%
(B/op) 32.00 B 32.00 B ⚪ 0%
(allocs/op) 1 allocs 1 allocs ⚪ 0%
BenchmarkLockerParallel
Benchmark suite Previous Current Change
(ns/op) 45.89 ns 44.75 ns 🟢 -2.48%
(B/op) 0.00 B 0.00 B ⚪ 0%
(allocs/op) 0 allocs 0 allocs ⚪ 0%
BenchmarkLockerMoreKeys
Benchmark suite Previous Current Change
(ns/op) 187.90 ns 174.30 ns 🟢 -7.24%
(B/op) 30.00 B 31.00 B 🔴 +3.33%
(allocs/op) 0 allocs 0 allocs ⚪ 0%
BenchmarkRWLocker
Benchmark suite Previous Current Change
RWLock_rate_2/ (ns/op) 50.93 ns 48.96 ns 🟢 -3.87%
RWLock_rate_2/ (B/op) 0.00 B 0.00 B ⚪ 0%
RWLock_rate_2/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
RWLock_rate_10/ (ns/op) 45.77 ns 42.67 ns 🟢 -6.77%
RWLock_rate_10/ (B/op) 0.00 B 0.00 B ⚪ 0%
RWLock_rate_10/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
RWLock_rate_100/ (ns/op) 61.23 ns 57.91 ns 🟢 -5.42%
RWLock_rate_100/ (B/op) 2.00 B 2.00 B ⚪ 0%
RWLock_rate_100/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
RWLock_rate_1000/ (ns/op) 89.26 ns 87.21 ns 🟢 -2.30%
RWLock_rate_1000/ (B/op) 8.00 B 8.00 B ⚪ 0%
RWLock_rate_1000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
BenchmarkChange
Benchmark suite Previous Current Change
Push_10_Changes/ (ns/op) 4.49 ms 4.43 ms 🟢 -1.33%
Push_10_Changes/ (B/op) 150.94 KB 150.63 KB 🟢 -0.21%
Push_10_Changes/ (allocs/op) 1,625 allocs 1,625 allocs ⚪ 0%
Push_100_Changes/ (ns/op) 16.40 ms 15.76 ms 🟢 -3.90%
Push_100_Changes/ (B/op) 776.10 KB 772.20 KB 🟢 -0.50%
Push_100_Changes/ (allocs/op) 8,511 allocs 8,511 allocs ⚪ 0%
Push_1000_Changes/ (ns/op) 131.30 ms 127.32 ms 🟢 -3.03%
Push_1000_Changes/ (B/op) 7.18 MB 7.30 MB 🔴 +1.66%
Push_1000_Changes/ (allocs/op) 79,325 allocs 79,326 allocs ⚪ 0%
Pull_10_Changes/ (ns/op) 3.69 ms 3.62 ms 🟢 -1.79%
Pull_10_Changes/ (B/op) 124.60 KB 124.96 KB 🔴 +0.29%
Pull_10_Changes/ (allocs/op) 1,454 allocs 1,454 allocs ⚪ 0%
Pull_100_Changes/ (ns/op) 5.26 ms 5.17 ms 🟢 -1.63%
Pull_100_Changes/ (B/op) 354.65 KB 355.55 KB 🔴 +0.25%
Pull_100_Changes/ (allocs/op) 5,180 allocs 5,179 allocs 🟢 -0.02%
Pull_1000_Changes/ (ns/op) 10.49 ms 10.72 ms 🔴 +2.12%
Pull_1000_Changes/ (B/op) 2.20 MB 2.20 MB 🟢 -0.11%
Pull_1000_Changes/ (allocs/op) 44,680 allocs 44,680 allocs ⚪ 0%
BenchmarkSnapshot
Benchmark suite Previous Current Change
Push_3KB_snapshot/ (ns/op) 18.53 ms 17.92 ms 🟢 -3.29%
Push_3KB_snapshot/ (B/op) 902.00 KB 898.59 KB 🟢 -0.38%
Push_3KB_snapshot/ (allocs/op) 8,514 allocs 8,512 allocs 🟢 -0.02%
Push_30KB_snapshot/ (ns/op) 132.49 ms 131.02 ms 🟢 -1.12%
Push_30KB_snapshot/ (B/op) 8.01 MB 8.33 MB 🔴 +3.95%
Push_30KB_snapshot/ (allocs/op) 86,458 allocs 89,964 allocs 🔴 +4.06%
Pull_3KB_snapshot/ (ns/op) 7.36 ms 7.25 ms 🟢 -1.49%
Pull_3KB_snapshot/ (B/op) 1.06 MB 1.06 MB 🔴 +0.16%
Pull_3KB_snapshot/ (allocs/op) 19,256 allocs 19,260 allocs 🔴 +0.02%
Pull_30KB_snapshot/ (ns/op) 19.29 ms 17.97 ms 🟢 -6.85%
Pull_30KB_snapshot/ (B/op) 8.77 MB 8.75 MB 🟢 -0.16%
Pull_30KB_snapshot/ (allocs/op) 185,629 allocs 185,664 allocs 🔴 +0.02%
BenchmarkSplayTree
Benchmark suite Previous Current Change
stress_test_100000/ (ns/op) 0.20 ns 0.19 ns 🟢 -3.58%
stress_test_100000/ (B/op) 0.00 B 0.00 B ⚪ 0%
stress_test_100000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
stress_test_200000/ (ns/op) 0.38 ns 0.37 ns 🟢 -4.03%
stress_test_200000/ (B/op) 0.00 B 0.00 B ⚪ 0%
stress_test_200000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
stress_test_300000/ (ns/op) 0.60 ns 0.57 ns 🟢 -5.95%
stress_test_300000/ (B/op) 0.00 B 0.00 B ⚪ 0%
stress_test_300000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
random_access_100000/ (ns/op) 0.01 ns 0.01 ns 🟢 -5.15%
random_access_100000/ (B/op) 0.00 B 0.00 B ⚪ 0%
random_access_100000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
random_access_200000/ (ns/op) 0.03 ns 0.03 ns 🔴 +11.32%
random_access_200000/ (B/op) 0.00 B 0.00 B ⚪ 0%
random_access_200000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
random_access_300000/ (ns/op) 0.04 ns 0.04 ns 🔴 +4.37%
random_access_300000/ (B/op) 0.00 B 0.00 B ⚪ 0%
random_access_300000/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
editing_trace_bench/ (ns/op) 0.00 ns 0.00 ns 🟢 -3.59%
editing_trace_bench/ (B/op) 0.00 B 0.00 B ⚪ 0%
editing_trace_bench/ (allocs/op) 0 allocs 0 allocs ⚪ 0%
BenchmarkSync
Benchmark suite Previous Current Change
memory_sync_10_test/ (ns/op) 7057.00 ns 6904.00 ns 🟢 -2.17%
memory_sync_10_test/ (B/op) 1.34 KB 1.34 KB 🟢 -0.07%
memory_sync_10_test/ (allocs/op) 35 allocs 35 allocs ⚪ 0%
memory_sync_100_test/ (ns/op) 54760.00 ns 54176.00 ns 🟢 -1.07%
memory_sync_100_test/ (B/op) 9.53 KB 9.51 KB 🟢 -0.24%
memory_sync_100_test/ (allocs/op) 269 allocs 268 allocs 🟢 -0.37%
memory_sync_1000_test/ (ns/op) 617621.00 ns 615047.00 ns 🟢 -0.42%
memory_sync_1000_test/ (B/op) 75.63 KB 75.30 KB 🟢 -0.44%
memory_sync_1000_test/ (allocs/op) 2,103 allocs 2,093 allocs 🟢 -0.48%
memory_sync_10000_test/ (ns/op) 7.83 ms 7.90 ms 🔴 +0.83%
memory_sync_10000_test/ (B/op) 752.23 KB 753.67 KB 🔴 +0.19%
memory_sync_10000_test/ (allocs/op) 20,417 allocs 20,431 allocs 🔴 +0.07%
BenchmarkTextEditing
Benchmark suite Previous Current Change
(ns/op) 5.20 s 5.11 s 🟢 -1.69%
(B/op) 3.92 GB 3.92 GB ⚪ 0%
(allocs/op) 20,619,784 allocs 20,619,832 allocs ⚪ 0%
BenchmarkTree
Benchmark suite Previous Current Change
10000_vertices_to_protobuf/ (ns/op) 4.29 ms 4.24 ms 🟢 -1.23%
10000_vertices_to_protobuf/ (B/op) 6.36 MB 6.36 MB ⚪ 0%
10000_vertices_to_protobuf/ (allocs/op) 70,025 allocs 70,025 allocs ⚪ 0%
10000_vertices_from_protobuf/ (ns/op) 222.46 ms 221.04 ms 🟢 -0.64%
10000_vertices_from_protobuf/ (B/op) 442.31 MB 442.30 MB ⚪ 0%
10000_vertices_from_protobuf/ (allocs/op) 290,039 allocs 290,058 allocs ⚪ 0%
20000_vertices_to_protobuf/ (ns/op) 9.14 ms 8.71 ms 🟢 -4.71%
20000_vertices_to_protobuf/ (B/op) 12.89 MB 12.89 MB ⚪ 0%
20000_vertices_to_protobuf/ (allocs/op) 140,028 allocs 140,028 allocs ⚪ 0%
20000_vertices_from_protobuf/ (ns/op) 877.37 ms 860.56 ms 🟢 -1.92%
20000_vertices_from_protobuf/ (B/op) 1.70 GB 1.70 GB ⚪ 0%
20000_vertices_from_protobuf/ (allocs/op) 580,090 allocs 580,044 allocs ⚪ 0%
30000_vertices_to_protobuf/ (ns/op) 13.15 ms 13.43 ms 🔴 +2.14%
30000_vertices_to_protobuf/ (B/op) 18.98 MB 18.98 MB ⚪ 0%
30000_vertices_to_protobuf/ (allocs/op) 210,029 allocs 210,030 allocs ⚪ 0%
30000_vertices_from_protobuf/ (ns/op) 2.02 s 1.97 s 🟢 -2.28%
30000_vertices_from_protobuf/ (B/op) 3.75 GB 3.75 GB ⚪ 0%
30000_vertices_from_protobuf/ (allocs/op) 870,086 allocs 870,051 allocs ⚪ 0%
BenchmarkVersionVector
Benchmark suite Previous Current Change
clients_10/ (ns/op) 157.85 ms 156.70 ms 🟢 -0.73%
clients_10/ (1_changepack(bytes)) 745.00 B 745.00 B ⚪ 0%
clients_10/ (2_snapshot(bytes)) 379.00 B 379.00 B ⚪ 0%
clients_10/ (3_pushpull(ms)) 7.00 ms 7.00 ms ⚪ 0%
clients_10/ (4_attach(ms)) 6.00 ms 6.00 ms ⚪ 0%
clients_10/ (5_changepack_after_detach(bytes)) 805.00 B 805.00 B ⚪ 0%
clients_10/ (6_snapshot_after_detach(bytes)) 136.00 B 136.00 B ⚪ 0%
clients_10/ (7_pushpull_after_detach(ms)) 8.00 ms 8.00 ms ⚪ 0%
clients_10/ (B/op) 20.71 MB 20.70 MB 🟢 -0.05%
clients_10/ (allocs/op) 83,248 allocs 83,241 allocs ⚪ 0%
clients_100/ (ns/op) 1.39 s 1.37 s 🟢 -1.26%
clients_100/ (1_changepack(bytes)) 6.14 KB 6.14 KB ⚪ 0%
clients_100/ (2_snapshot(bytes)) 3.08 KB 3.08 KB ⚪ 0%
clients_100/ (3_pushpull(ms)) 11.00 ms 11.00 ms ⚪ 0%
clients_100/ (4_attach(ms)) 9.00 ms 9.00 ms ⚪ 0%
clients_100/ (5_changepack_after_detach(bytes)) 6.21 KB 6.21 KB ⚪ 0%
clients_100/ (6_snapshot_after_detach(bytes)) 137.00 B 137.00 B ⚪ 0%
clients_100/ (7_pushpull_after_detach(ms)) 9.00 ms 10.00 ms 🔴 +11.11%
clients_100/ (B/op) 213.58 MB 210.99 MB 🟢 -1.21%
clients_100/ (allocs/op) 1,481,342 allocs 1,481,082 allocs 🟢 -0.02%
clients_1000/ (ns/op) 42.35 s 41.79 s 🟢 -1.33%
clients_1000/ (1_changepack(bytes)) 60.16 KB 60.16 KB ⚪ 0%
clients_1000/ (2_snapshot(bytes)) 30.08 KB 30.08 KB ⚪ 0%
clients_1000/ (3_pushpull(ms)) 116.00 ms 113.00 ms 🟢 -2.59%
clients_1000/ (4_attach(ms)) 72.00 ms 73.00 ms 🔴 +1.39%
clients_1000/ (5_changepack_after_detach(bytes)) 60.22 KB 60.22 KB ⚪ 0%
clients_1000/ (6_snapshot_after_detach(bytes)) 139.00 B 139.00 B ⚪ 0%
clients_1000/ (7_pushpull_after_detach(ms)) 27.00 ms 22.00 ms 🟢 -18.52%
clients_1000/ (B/op) 6.43 GB 6.43 GB ⚪ 0%
clients_1000/ (allocs/op) 93,354,528 allocs 93,354,503 allocs ⚪ 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants