Clean up converter

admin/client.go

@@ -174,39 +174,39 @@ func (c *Client) SignUp(
 func (c *Client) CreateProject(ctx context.Context, name string) (*types.Project, error) {
 	response, err := c.client.CreateProject(
 		ctx,
-		connect.NewRequest(&api.CreateProjectRequest{
-			Name: name,
-		},
-		))
+		connect.NewRequest(&api.CreateProjectRequest{Name: name}),
+	)
 	if err != nil {
 		return nil, err
 	}
 
-	return converter.FromProject(response.Msg.Project)
+	return converter.FromProject(response.Msg.Project), nil
 }
 
 // GetProject gets the project by name.
 func (c *Client) GetProject(ctx context.Context, name string) (*types.Project, error) {
 	response, err := c.client.GetProject(
 		ctx,
-		connect.NewRequest(&api.GetProjectRequest{Name: name}))
+		connect.NewRequest(&api.GetProjectRequest{Name: name}),
+	)
 	if err != nil {
 		return nil, err
 	}
 
-	return converter.FromProject(response.Msg.Project)
+	return converter.FromProject(response.Msg.Project), nil
 }
 
 // ListProjects lists all projects.
 func (c *Client) ListProjects(ctx context.Context) ([]*types.Project, error) {
 	response, err := c.client.ListProjects(
 		ctx,
-		connect.NewRequest(&api.ListProjectsRequest{}))
+		connect.NewRequest(&api.ListProjectsRequest{}),
+	)
 	if err != nil {
 		return nil, err
 	}
 
-	return converter.FromProjects(response.Msg.Projects)
+	return converter.FromProjects(response.Msg.Projects), nil
 }
 
 // UpdateProject updates an existing project.
@@ -228,7 +228,7 @@ func (c *Client) UpdateProject(
 		return nil, err
 	}
 
-	return converter.FromProject(response.Msg.Project)
+	return converter.FromProject(response.Msg.Project), nil
 }
 
 // ListDocuments lists documents.
@@ -254,7 +254,7 @@ func (c *Client) ListDocuments(
 		return nil, err
 	}
 
-	return converter.FromDocumentSummaries(response.Msg.Documents)
+	return converter.FromDocumentSummaries(response.Msg.Documents), nil
 }
 
 // RemoveDocument removes a document of the given key.
@@ -277,7 +277,8 @@ func (c *Client) RemoveDocument(
 			DocumentKey: documentKey,
 			Force:       force,
 		},
-		), apiKey, documentKey))
+		), apiKey, documentKey),
+	)
 	return err
 }
 

api/converter/from_pb.go

@@ -41,23 +41,16 @@ func FromUser(pbUser *api.User) (*types.User, error) {
 }
 
 // FromProjects converts the given Protobuf formats to model format.
-func FromProjects(pbProjects []*api.Project) ([]*types.Project, error) {
+func FromProjects(pbProjects []*api.Project) []*types.Project {
 	var projects []*types.Project
 	for _, pbProject := range pbProjects {
-		project, err := FromProject(pbProject)
-		if err != nil {
-			return nil, err
-		}
-		projects = append(projects, project)
+		projects = append(projects, FromProject(pbProject))
 	}
-	return projects, nil
+	return projects
 }
 
 // FromProject converts the given Protobuf formats to model format.
-func FromProject(pbProject *api.Project) (*types.Project, error) {
-	createdAt := pbProject.CreatedAt.AsTime()
-	updatedAt := pbProject.UpdatedAt.AsTime()
-
+func FromProject(pbProject *api.Project) *types.Project {
 	return &types.Project{
 		ID:                        types.ID(pbProject.Id),
 		Name:                      pbProject.Name,
@@ -66,37 +59,30 @@ func FromProject(pbProject *api.Project) (*types.Project, error) {
 		ClientDeactivateThreshold: pbProject.ClientDeactivateThreshold,
 		PublicKey:                 pbProject.PublicKey,
 		SecretKey:                 pbProject.SecretKey,
-		CreatedAt:                 createdAt,
-		UpdatedAt:                 updatedAt,
-	}, nil
+		CreatedAt:                 pbProject.CreatedAt.AsTime(),
+		UpdatedAt:                 pbProject.UpdatedAt.AsTime(),
+	}
 }
 
 // FromDocumentSummaries converts the given Protobuf formats to model format.
-func FromDocumentSummaries(pbSummaries []*api.DocumentSummary) ([]*types.DocumentSummary, error) {
+func FromDocumentSummaries(pbSummaries []*api.DocumentSummary) []*types.DocumentSummary {
 	var summaries []*types.DocumentSummary
 	for _, pbSummary := range pbSummaries {
-		summary, err := FromDocumentSummary(pbSummary)
-		if err != nil {
-			return nil, err
-		}
-		summaries = append(summaries, summary)
+		summaries = append(summaries, FromDocumentSummary(pbSummary))
 	}
-	return summaries, nil
+	return summaries
 }
 
 // FromDocumentSummary converts the given Protobuf formats to model format.
-func FromDocumentSummary(pbSummary *api.DocumentSummary) (*types.DocumentSummary, error) {
-	createdAt := pbSummary.CreatedAt.AsTime()
-	accessedAt := pbSummary.AccessedAt.AsTime()
-	updatedAt := pbSummary.UpdatedAt.AsTime()
+func FromDocumentSummary(pbSummary *api.DocumentSummary) *types.DocumentSummary {
 	return &types.DocumentSummary{
 		ID:         types.ID(pbSummary.Id),
 		Key:        key.Key(pbSummary.Key),
-		CreatedAt:  createdAt,
-		AccessedAt: accessedAt,
-		UpdatedAt:  updatedAt,
+		CreatedAt:  pbSummary.CreatedAt.AsTime(),
+		AccessedAt: pbSummary.AccessedAt.AsTime(),
+		UpdatedAt:  pbSummary.UpdatedAt.AsTime(),
 		Snapshot:   pbSummary.Snapshot,
-	}, nil
+	}
 }
 
 // FromChangePack converts the given Protobuf formats to model format.

server/rpc/server.go

@@ -74,13 +74,11 @@ func NewServer(conf *Config, be *backend.Backend) (*Server, error) {
 		newAdminServer(be, tokenManager),
 		interceptor,
 	))
-
-	checker := grpchealth.NewStaticChecker(
+	serverMux.Handle(grpchealth.NewHandler(grpchealth.NewStaticChecker(
 		grpchealth.HealthV1ServiceName,
 		v1connect.YorkieServiceName,
 		v1connect.AdminServiceName,
-	)
-	serverMux.Handle(grpchealth.NewHandler(checker))
+	)))
 
 	return &Server{
 		conf:                conf,